this post was submitted on 09 Oct 2023
12 points (92.9% liked)

Voyager

5520 readers
16 users here now

The official lemmy community for Voyager, an open source, mobile-first client for lemmy.

Download on App Store

Download on Play Store

Use as a Web App

Download on F-Droid

Rules

  1. Be nice.
  2. lemmy.world instance policy

Sponsor development! πŸ‘‡

Number of sponsors badge

πŸ’™

founded 1 year ago
MODERATORS
 

Since there is no way currently to quickly and easily subscribe to a community from the search menu, sharunkumar (not me) added a way to do that in this pull request.

There are 2 poosible designs that are consistent with UI of voyager so I will comment the images of the design below. Upvote the design that you prefer. Please refrain from downvoting.

Also it would be appreciated if the mod (@[email protected] @[email protected]) can pin this post (for a day or two) to ensure that it reaches most members of the community

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 1 points 1 year ago (1 children)

A favourite is not a subscription, right? Although, I've got to agree with you that a consistent style across favourites and subscriptions would be nice

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago) (1 children)

No they aren't the same. I just thought the design would be more consistent as both of them are options living outside the ellipsis menu.

Also I edited my comment above. Care to weigh in on the discussion thereΒΏ?

[–] [email protected] 1 points 1 year ago (1 children)

Reading the Apple Human Interface Guideline, it states the following:

If you use a button that behaves like a toggle, you generally use an interface icon that communicates its purpose, and you update its appearance β€” typically by changing the background β€” based on the current state.

So Design 1 lays closest to best practice. Regarding the ellipsis menu, I'm not sure what to do there. I'd really like a consistent approach, but a stroke-and-filled state might lead to more confusion than what's there currently. I'm all in on your Design 1 right now.

[–] [email protected] 1 points 1 year ago

It is not my design. I just gave some inputs. All credits for the design and the pull request go to https://github.com/sharunkumar