JetBrains

71 readers

2 users here now

A community for discussion and news relating to JetBrains and its products! https://www.jetbrains.com/

Related Communities

founded 8 months ago

MODERATORS

[email protected]

After seeing people use the UI to commit to git I understand where all those - sorry: shitty - commit messages come from.... (phpc.social)

submitted 2 days ago by [email protected] to c/[email protected]

34 comments fedilink hide all child comments

After seeing people use the @jetbrains UI to commit to git I understand where all those - sorry: shitty - commit messages come from....

🙈

An improvement would already be to have a "Subject" line and the text box.

And have the subject line follow the Beams Rule.

Sonthat the first line of the commit message finishes the sentence

"When this commit is applied it will..."

And please: No longer than 56(?) characters (Unicode). Keep it short. You got the textbox to explain *why* in full length.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 3 points 2 days ago (27 children)

@heiglandreas @jetbrains What if you want to use Conventional Commits instead of Beams? 😉

[–] [email protected] -1 points 2 days ago (26 children)

@ramsey Just: Don't.

The subject lines space is limited and should not be wasted for stuff that doesn't belong there.

Also the prime idea behind conventional commits is to add machine readable info.to the commit message: Fine. Do so. The commit.meysage can be as long as you want. Add it there. Keep the subject line to the human readable part.

Also: Creating changelogs from.git.commits is *not* what chamgelogs are there for.

Keep a changelog can help on *that* front.

@jetbrains

[–] [email protected] 1 points 1 day ago (1 children)

@heiglandreas @ramsey @jetbrains see, that's exactly *why* IntelliJ shouldn't have a default opinion on this. Why wouldn't they choose these conventions? They're popular.

Instead they should have the safest possible default, and let you easily configure your own conventions. When possible, by reading git configuration for anything standard. Which is what IntelliJ already does.

[–] [email protected] 1 points 1 day ago (2 children)

@clovis

We might be talking about two different sets of standard. What I would want Jetbrains to support out of the box is the "Subject line, Blank Line, Body" convention that is recommended in the git docs.

People can happily change the defaults to whatever they want but the recommendation from git should IMO be the default.

/cc @ramsey @jetbrains

[–] [email protected] 1 points 1 day ago (1 children)

@heiglandreas @ramsey @jetbrains how do you expect IntelliJ to support this? When if the second line isn't blank?

[–] [email protected] 1 points 1 day ago (1 children)

@clovis They already DO support it.

/cc @ramsey @jetbrains

[–] [email protected] 1 points 1 day ago

@heiglandreas @ramsey @jetbrains what's the problem then 😅

[–] [email protected] 1 points 1 day ago

@clovis

Whether the users then use conventional commits, beams rule, opensavvy, whatever else they want is a completely different question.

And I am absolutely with you that Jetbrains should not favour one over the other.

/cc @ramsey @jetbrains

load more comments (24 replies)